[Flutter] fix: remove v1 embedding support
Description
Flutter 3.29.0 removed the previously deprectaed registrar (io.flutter.plugin.common.PluginRegistry.Registrar), this pr fixes building by removing support for it
Type of Change
- Bug fix
Checks
- [x] Changes support all platforms (
Android,iOS,Linux,macOS,tvOS)- change only affects android
- [ ] Breaks existing functionality
- the plugin already didnt use the registrar, it always supplied its value by
null
- the plugin already didnt use the registrar, it always supplied its value by
- [x] Implementation is completed, not half-done
- [x] Is there another PR already created for this feature/bug fix
- nope
Tests
- upgrade to flutter v3.29.0
- run
flutter build --releasefor the flutter project - it should build successfuly
reference
fixes issue at #1110
As previously communicated, this project has been retired. We will not be reviewing or merging any pull requests.
thats very sad. i was hoping for a merge just to be able to use the lts version
im sorry if this is a duplicate question but is there an alternative to using it like this but with the fork fix?
ffmpeg_kit_flutter_min: "6.0.3-LTS"
currently doing this but its not the lts version
ffmpeg_kit_flutter:
git:
url: https://github.com/MSOB7YY/ffmpeg-kit
path: flutter/flutter
You'll need to update the dependencies to achieve that.
These two lines determine whether the Flutter plugin version is LTS or not. If you add -lts to the package name (e.g. http-lts for iOS, ffmpeg-kit-https-lts for Android), the package will be recognized as LTS.
https://github.com/arthenica/ffmpeg-kit/blob/v6.0/flutter/flutter/android/build.gradle#L52 https://github.com/arthenica/ffmpeg-kit/blob/v6.0/flutter/flutter/ios/ffmpeg_kit_flutter.podspec#L18
thank u so much for the clarification ❣️ just read ur medium article and wish u luck for ur life 😊 much thanks for ur generous efforts ^^
@MSOB7YY sorry how can I choose a package using your repo? previously I used ffmpeg_kit_flutter_full_gpl, but I guess your repo does not support variability of configs?
@asmodeoux yeah it doesnt, u need to manually modify parts as @ tanersener mentioned in https://github.com/arthenica/ffmpeg-kit/pull/1111#issuecomment-2669582875
or maybe check other forks that might have better management
@tanersener
Please prepare an article on how to use it locally, especially for Flutter, before deleting the binary files. ❤️
For those that need this, just use git as a package with this ref (thanks @MSOB7YY !)
ffmpeg_kit_flutter:
git:
url: https://github.com/MSOB7YY/ffmpeg-kit
path: flutter/flutter
ref: 1d29b16