seotools icon indicating copy to clipboard operation
seotools copied to clipboard

Default configuration obsolete

Open jakemitchellxyz opened this issue 8 years ago • 2 comments

The defaults config file that gets published is barely used, and when it is, it is very inconsistent. I think we should either get rid of it entirely and rely on built-in defaults on the parameters, or rely more heavily on it in a much more consistent manner. What do you think?

jakemitchellxyz avatar Jun 24 '16 22:06 jakemitchellxyz

The idea of the package is to be the less "intrusive" possible, and easy to use. However there is always the possibility of improvement. You can demonstrate how you think you can improve?

vinicius73 avatar Jun 24 '16 23:06 vinicius73

My suggestion is to make it so the user never has to issue php artisan vendor:publish and the defaults will be built into each function if necessary. I'll create a repo and pull it when I am finished so you can better understand how that would work and if you like it. It'll make the code much more consistent and it will be very easy for the user to create their own defaults if they choose to, but they will also have the option of no defaults if they want.

jakemitchellxyz avatar Jun 24 '16 23:06 jakemitchellxyz

The current way forward within the Laravel eco system seems to continue using config files rather than the defaults hard coded in the package. Combined with that no commit was ever provided I will close this issue.

J-Brk avatar Aug 30 '22 00:08 J-Brk