marksman icon indicating copy to clipboard operation
marksman copied to clipboard

Disingenuous Behavior Discrepancies

Open uvb1 opened this issue 7 months ago • 1 comments

Using terminology from the README for relatability.

Issue:

Release 6c8e995 2023-11-29, broke diagnostics for both markdown inline links and markdown reference links.

Semantic Versioning has been in use. marksman --version has returned a major.minor version scheme of 1.0 both before and after this breaking release. A breakage such as this should be indicated by an increase in the major version according the rules of semantic versioning.

However, none of the following seem to have been performed:

  • No increment in the major version.
  • No indication in the release notes that a breakage would be introduced.
  • No call out in the README that a breakage would be or had been introduced.

All functionality seems to work for wiki-links. However, marksman seems to have narrowed its primary focus to Wikis and made standard markdown a second class citizen.

For markdown links:

  • Diagnostics do not work for markdown inline or markdown reference links.
  • Hover does not work for markdown reference links.
  • Go-to-definition does not work for markdown reference links.

Summary: The README is misleading.

The README starts by stating in bold that diagnostics are provided (no caveats are provided). Markdown link styles are then illustrated first, before wiki-links (implying they are a first class citizen). A small caveat later in the README only implies that "Marksman provides diagnostics for wiki-links." The demo and feature links don't call out these deficiencies for standard markdown links.

Recommendation:

Make it abundantly clear up front:

  • That wiki-links are the focus and the only link type with full functionality.
  • To existing users that this breaking change for markdown links was introduced.
  • The intentions of the project going forward for support of markdown link functionality vs wiki-links.

uvb1 avatar Jun 29 '24 17:06 uvb1