Artem Pavlenko comments

Results 235 comments of


                                            Artem Pavlenko

New release

@snickell yes, thanks for reminding :) My plan is to release mapnik 4.x.x (master) followed by `python-mapnik` and `node-mapnik`

Datasource sometimes adds `null` attribute to a feature when it lacks an attribute another feature has

@davidtheclark - I'll take a look tomorrow, thanks for reporting.

Datasource sometimes adds `null` attribute to a feature when it lacks an attribute another feature has

Using `mapnik-python` ``` python for f in ds.all_features(): ... print(f["astonishing"],f["mixed"],f["numbers"],f["power"],f["name"]) ... True 7 [1,2,3] 6 foo None 7 None 99 bar None None None None baz None None None None...

Datasource sometimes adds `null` attribute to a feature when it lacks an attribute another feature has

After some digging it turned out that the best place to fix this is in https://github.com/mapnik/mapnik `feature_kv_iterator` https://github.com/mapnik/mapnik/commit/3397b8f14fa649f8907bd7b2974f1b5792cf99ef#diff-7e10cfbdff7fca38fb1824d1ce771d88R42 ^ I modified `feture_kv_iterator` to skip over non-existent values and also fix...

Datasource sometimes adds `null` attribute to a feature when it lacks an attribute another feature has

@springmeyer - yes, confirming I'm seeing those as well ^. Back to debugging :)

Datasource sometimes adds `null` attribute to a feature when it lacks an attribute another feature has

Doh ;) Summary: our trick to use mapnik::value_null as a placeholder for Features that don’t actually have particular attribute is getting problematic. Specially if we want to maintain 1:1 matching...

Datasource sometimes adds `null` attribute to a feature when it lacks an attribute another feature has

To distill even further: If we want to support "null" values (i think we do because they are valid in GeoJSON) then we can't rely on `mapnik::value_null` as a special...

Datasource sometimes adds `null` attribute to a feature when it lacks an attribute another feature has

``` js > d={"name":null} { name: null } > d["name"] null > d["undefined"] undefined > ``` In JavaScript _null_ is a distinct type that can be assigned ^ /cc @springmeyer...

Datasource sometimes adds `null` attribute to a feature when it lacks an attribute another feature has

To properly support `null` values in JSON input and output we need to change `mapnik::feature_impl` - I'm planning to work on this next week. Meanwhile, I added `properties` method which...

Datasource sometimes adds `null` attribute to a feature when it lacks an attribute another feature has

@springmeyer - great catch before `mapnik v3.0.12` release! The issue was missing quoting for nested objects (https://github.com/mapnik/mapnik/issues/3491) and it's not related to indexing so please verify your setup ^. We...