Artem Pavlenko

Results 235 comments of Artem Pavlenko

@ShapovalovKL thanks for highlighting! It does look like a bug in text bounds calculations in `v3.0.x`. Have you tried running the same test with `master`?

> > > > I just ran the same test with the latest version from master ([1ba1278](https://github.com/mapnik/mapnik/commit/1ba1278b4227ccd887a95880d1c75aa6446132fc)) and it gave exactly the same results as with 3.0.22. @ShapovalovKL ok, thanks!

@ShapovalovKL - So it looks like we should be keeping track of both `ymin` and `ymax` in order to calculate correct `max_glyph_height`. :+1: for the comprehensive use case demonstrating this...

Related issues * https://github.com/mapnik/mapnik/issues/2928 * https://github.com/mapnik/mapnik/issues/3530

@ShapovalovKL - The bounds are not including descender (part of glyph below baseline). It was left like that for some reason and I don't remember details now. I've tried fixing...

@ShapovalovKL https://github.com/mapnik/mapnik/tree/label-bbox - my attempt so far to fix label bounding box calculation. This is WIP as lots of visual tests are failing ![top](https://user-images.githubusercontent.com/59056/165114294-1d1010ba-2e1e-49dd-917c-9f1432df8664.png) ![bottom](https://user-images.githubusercontent.com/59056/165114319-e9c86073-9548-4bd5-892e-ede5e76971ba.png)

@StyXman - How can I replicate this locally? Could you provide some input data, pls ? Also, mapnik version ? Cheers.

> I'm trying to come up with one. Debugging `mapnik` is not that easy to me. Thanks for trying! I think the easiest way to replicate this would be a...

@sarpsarpp Try using [proj6 branch](https://github.com/mapnik/python-mapnik/tree/proj6) with latest mapnik master

@Andrey-VI - could you check and resolve conflicts (rebase on latest master?), pls?