sasha icon indicating copy to clipboard operation
sasha copied to clipboard

Remove hardcoded paths for .sketch files

Open artemnovichkov opened this issue 8 years ago β€’ 5 comments

project command creates a folder structure and copies .sketch files. Paths for the files are hardcoded: https://github.com/artemnovichkov/sasha/blob/e58db8f8d14c65dfbc466cf34810328df4680743/Sources/SashaCore/Tasks/ProjectTask.swift#L52-L62 I want to update project.sasha configuration file format and add possibility to add these paths, for example:

Main
-folder
--{ sketch_ios.sketch }

Also, I want to improve parsing of configuration files: https://github.com/artemnovichkov/sasha/blob/e58db8f8d14c65dfbc466cf34810328df4680743/Sources/SashaCore/Services/FolderService.swift#L36-L68

artemnovichkov avatar Oct 18 '17 06:10 artemnovichkov

@artemnovichkov Maybe this will also help. After clean installing sasha. I get the following output.

/usr/local/Cellar/sasha/2.0.3
β”œβ”€β”€ INSTALL_RECEIPT.json
β”œβ”€β”€ LICENSE
β”œβ”€β”€ README.md
└── bin
    └── sasha

1 directory, 4 files

stalinkay avatar Oct 20 '17 19:10 stalinkay

@stalinkay, this issues is not related to installation. When you run project command, Sasha also adds .sketch templates. But paths for these files are hardcoded.

artemnovichkov avatar Oct 21 '17 05:10 artemnovichkov

@artemnovichkov Cool. There's currently no file at ~/.sasha/project.sasha, in fact ~/.sasha is never created.

stalinkay avatar Oct 21 '17 07:10 stalinkay

I guess I forgot to add coping of project.sasha here: https://github.com/artemnovichkov/sasha/blob/e58db8f8d14c65dfbc466cf34810328df4680743/Makefile#L22-L24 It would be great if you fix it

artemnovichkov avatar Oct 21 '17 10:10 artemnovichkov

@artemnovichkov Cool. I'll hop on it.

stalinkay avatar Oct 21 '17 13:10 stalinkay