Artem Bilan

Results 616 comments of Artem Bilan

The `DefaultKafkaSender` has this logic: ``` public void close() { if (!hasProducer.getAndSet(false)) { return; } producerMono.doOnNext(producer -> producer.close(senderOptions.closeTimeout())) .block(); if (senderOptions.isTransactional()) { senderOptions.scheduler().dispose(); } scheduler.dispose(); } ``` So, we really...

May we see a memory report where you think it is a leak? I'm not sure that I'm going to run your program for 12 hours... May this behavior can...

OK. When I moved that `sender.close()` out of the `doFinally()`, just as the last line of that cycle, I don't see any problems with the memory from VisualVM. So, it...

Yeah... I see your point. We will discuss with @garyrussell what we can do on the matter (e.g. exception), when he comes back from PTO next week.

Looking to that project, @pdebuitlear , I would say that I don't see anything Spring Cloud Stream related or even Spring at all. It really would be better to have...

Of course no, because those types and resources are exactly from Kafka Streams project. And I believe that we have to expose them even if we just try to build...

I don’t find it as a correct comparison: such a native hint really has to be in that library, not any framework. This way all the frameworks and any library...

What if I don’t want Quarkus and just want to build native app just with plain Kafka Streams? Why would I always go for Quarkus just because it exposes hints...

We currently don’t set any such a header and fully rely on whatever broker gives us in that `x-death` header. So, why is the request, please?

OK. I see now. So, reopening respective Spring AMQP issue: https://github.com/spring-projects/spring-amqp/issues/2688. Not sure, though, what you mean about fixing Rabbit Binder, but probably that fails just to the docs as...