artem avetisyan
artem avetisyan
> Other call out is the addition of the dexie dependency Adding dexie seems reasonable to me.
I take it this one _is_ still a draft? ``` $ webpack --watch [webpack-cli] Failed to load '/home/artem/projects/translate_onhover/webpack.config.js' config [webpack-cli] Error [ERR_REQUIRE_ESM]: require() of ES Module /home/artem/projects/translate_onhover/node_modules/web-ext-plugin/index.js from /home/artem/projects/translate_onhover/webpack.config.js not...
Would be nice to add tests for those cases.
Nice! Lint needs fixing (you can run `make` locally to see failures), otherwise lgtm.
> Hi! following up on this PR. Fixed the lint errors Oops. Sorry, forgot about it. Just ran the build and got some test failures. Do you not get those...
> On the other hand, this specific test: > > https://github.com/artemave/tmux_super_fingers/blob/6b27a8c7a2a2ed97b8dd38d18cf403b6250c42b9/tmux_super_fingers/finders/file_path_finder_test.py#L126-L142 > > Seems to be failing even on a freshly cloned repo. I wonder if it's an osx thing...
Thanks for the heads up! Finally. I'll most likely archive this project once it's released.