Problem: Reports not available when information is present on lower levels but not target description

[fiver-watson]

Current Behavior

Steps to reproduce the behavior

1. Find or create a multi-level archival unit - e.g. one that includes a Series-level description with a number of files and items below it
2. Ensure that the files and items have storage location information attached to them
3. Ensure that the Series-level parent does NOT have any storage location information attached
4. Attempt to generate a storage location or box label report from the series

Expected Behavior

• The reports are available to generate when relevant information for the report is included in any descendant level - i.e. so long as the report will not be blank, then the option to generate it should be present.
• No storage location should need to be present directly on the parent level from which a user generates a report if it is included at lower levels

Possible Solution

See above

Context and Notes

First reported in the user forum, 2023-11-10:

• https://groups.google.com/g/ica-atom-users/c/y2GWgJkmBwQ/m/PNoDksf0BgAJ

Reproduced in the public demo site, and locally in my Docker environment.

---

This is a result of the fix applied to the following issue:

• https://projects.artefactual.com/issues/13553

In this commit:

• https://github.com/artefactual/atom/commit/8408d544299558e81b0da2cfc87be4c5c3854042

The result comes from too much domain-specific language in the description, and/or not being explicit enough in the issue description.

The fixes applied worked properly for the file/item reports: if there are no files at lower levels, then no file report should be available to generate (and same with items).

For the second issue on the ticket, the Expected result described on issue ticket says:

Options to generate reports should not be displayed if the requisite information to create the report is not present on the target archival unit

However, archival unit was meant to mean the entire archival hierarchy, and not the specific description in question as it was understood by the developer. Consequently, the solution applied to this second case is a bit too aggressive, and reports that should be available no longer are.

This should be changed so that the check determines whether or not there are any storage locations on the current description AND/OR ANY DESCENDANT LEVELS. If yes, then the option to generate the locations and/or box label reports should be available.

Version used

AtoM 2.7.3 - 192

Operating System and version

Ubuntu 20.04

Default installation culture

en

PHP version

PHP 7.4

Contact details

No response