archivematica-storage-service icon indicating copy to clipboard operation
archivematica-storage-service copied to clipboard

Published 20 hours ago • verified publisher icon artefactual

delete source path after moving

Open fitnycdigitalinitiatives opened this issue 2 years ago • 3 comments

Piggybacking off of #632, even if the pointer file is successfully recreated, I don't think 'move' is working fully as intended because it doesn't delete the original package in the source after the move. Though, I'm not sure if that was the intent to leave the original there. In the SS api, it uses the term 'relocate' so I'm assuming that the intent is to remove the original files in the source. This uses 'delete_path' to do so.

fitnycdigitalinitiatives avatar Jul 08 '22 19:07 fitnycdigitalinitiatives

I will try to start the tests by closing/re-opening the branch...

eviau-artefactual avatar Feb 02 '24 14:02 eviau-artefactual

@fitnycdigitalinitiatives :Thank you for the contribution!

Based on the results of the tests, it appears that the linting test failed. Would it be possible for you to fix the linting issue ? There is a pre-commit setup you can create. It should be done pre-commit install inside the git repo.

Thanks!

Dhwaniartefact avatar Feb 02 '24 17:02 Dhwaniartefact

Ok, let me see when I can get to this, it's been a while since I worked on this.

fitnycdigitalinitiatives avatar Feb 05 '24 19:02 fitnycdigitalinitiatives