Artemis Sparks
Artemis Sparks
We should add an Equal method to move.List. This allows us to use cmp.Equal See * Cmp documentation: https://pkg.go.dev/github.com/google/go-cmp/cmp * Move List: https://github.com/otrego/clamshell/tree/master/core/move Note that Equal methods must have the...
Currently point uses int64. This is overkill and also makes iteration more annoying: https://stackoverflow.com/questions/34811167/can-i-make-the-index-int64-in-golangs-for-range-iteration Int64 is massively overkill for golang points, so there's no reason we need to continue using...
We should add automatic code-coverage checking via github actions. This would help to ensure the quality of the code automatically. It should be implemented with care so that it's not...
We should add a `String` method to `movetree.Node`. It would be very useful for debugging. See: https://github.com/otrego/clamshell/blob/master/core/movetree/node.go
We should add some methods to indicate correctness for problems. Historically, the way I've done this is to add a `GB[1]` property to the nodes. https://github.com/Kashomon/glift-core/blob/master/src/rules/problems.js has more ideas --...
We should add validation to `board.SetPlacements`. At present, SetPlacements looks like: ```go func (b *Board) SetPlacements(ml move.List) error { for _, m := range ml { b.setColor(m) } return nil...
We should add a public `Ko()` method to `board.Board` to return the ko-point on the board. Such a method should have: - Documentation - Basic unit tests. See more https://golang.org/pkg/testing/
Follow-up from #132 and #185 -- We should add some unit-tests for the new cropping library.
We should add a converter for the BlackRank & WhiteRank properties + fields in the `GameInfo` struct in node.go: https://github.com/otrego/clamshell/blob/master/core/movetree/node.go Extra care will need to be paid to ensure that...
We should add a converter for the PlayerBlack & PlayerWhite properties + fields in the `GameInfo` struct in node.go: https://github.com/otrego/clamshell/blob/master/core/movetree/node.go Extra care will need to be paid to ensure that...