odmantic icon indicating copy to clipboard operation
odmantic copied to clipboard

Motor `get_database` method additional kwargs support

Open Olegt0rr opened this issue 3 years ago • 4 comments

Relates to #70

Olegt0rr avatar Dec 11 '20 13:12 Olegt0rr

Codecov Report

Merging #71 (914d494) into master (02a7ca7) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #71   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          883       886    +3     
  Branches       143       143           
=========================================
+ Hits           883       886    +3     
Flag Coverage Δ
tests-3.6-4 99.08% <100.00%> (+<0.01%) :arrow_up:
tests-3.6-4.2 99.08% <100.00%> (+<0.01%) :arrow_up:
tests-3.6-4.4 99.08% <100.00%> (+<0.01%) :arrow_up:
tests-3.7-4 98.51% <100.00%> (+<0.01%) :arrow_up:
tests-3.7-4.2 98.51% <100.00%> (+<0.01%) :arrow_up:
tests-3.7-4.4 98.51% <100.00%> (+<0.01%) :arrow_up:
tests-3.8-4 98.30% <100.00%> (+<0.01%) :arrow_up:
tests-3.8-4.2 98.30% <100.00%> (+<0.01%) :arrow_up:
tests-3.8-4.4 98.30% <100.00%> (+<0.01%) :arrow_up:
tests-3.9-4 98.19% <100.00%> (+<0.01%) :arrow_up:
tests-3.9-4.2 98.19% <100.00%> (+<0.01%) :arrow_up:
tests-3.9-4.4 98.19% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
odmantic/engine.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 02a7ca7...914d494. Read the comment docs.

codecov[bot] avatar Dec 11 '20 13:12 codecov[bot]

pymongo is a dependency of motor, but importing objects from pymongo make build / static-analysis (pull_request) failed Seems it's a new issue for static-analysis stage

Olegt0rr avatar Dec 11 '20 13:12 Olegt0rr

Since motor depends on it, you can add it to the known third party of isort (in the pyproject.toml). It will then be aware that this package should be considered like that. Otherwise if you run isort locally, with task lint for example, it should add it automatically there.

art049 avatar Dec 11 '20 18:12 art049

This should close #118

ivan-gj avatar Jan 29 '23 19:01 ivan-gj