Arthur Pastel

Results 63 comments of Arthur Pastel

Thanks for the suggestion. I'm not sure this is related to `upsert` maybe there is a simpler way to fix that. I'll have a look.

Yes this is the expected behavior. To create an index on an embedded model, you should define it in the root model: ```python class User(EmbeddedModel): name: str class Product(Model): owner:...

Totally agree, it could be very handy. I'll include it in the reference rework!

Hey, thanks a lot. I'll have a look!

I think we can probably merge after the v1 release :) Btw with the bench, the speedup is amazing; this is super exciting, thank you. :clap:

Hey @0nf and @DanielNoord, I've been running the benches on this branch, and these changes seem to significantly impact the baseline benchmarks and from their definition, those seem important: https://github.com/pylint-dev/pylint/blob/67bfab41b6a830cbab669b4eb15204690c64846d/tests/benchmark/test_baseline_benchmarks.py#L118-L124...

@DanielNoord yes it seems from the differential profile the regressions is mainly located in `PyLinter._get_namespace_for_file`: A lot of new code(in blue) is executed here.

Hey @Rak424 and @pubpub-zz, We've been running the benches on this branch, and it seems these changes are significantly improving the `PDFWriter` performance. I think it's worth considering in merging...

> If I read the detailed results correctly, this is a 4% difference on 1s. Can we really consider this a "significant improvement"? It may seem small, but with over...