aic-mobile-android

aic-mobile-android copied to clipboard

Correct some ConstraintLayout usage

1

We disabled the `MissingConstraints` Lint check a while ago, and just today I merged in #363 to disable `NotSibling` as well. These sorts of issues can (and do) break the...

Cliabhach

The cause behind this issue was the logic we used to get column number for suggested artworks. That logic was based on the position of the `on the map` cell....

sam33rdhakal

This mostly just removes some duplicate code. There's also some better documentation of the various `All` fragments. This PR is on hold until #297 and #299 are merged in. It...

Cliabhach

This corresponds to the problems we saw in #358 and #357 , under ticket AIC-646. Put simply, if we define then RxJava2 calls such as [this one](https://github.com/art-institute-of-chicago/aic-mobile-android/blob/92059159029f014c690797ba6e2c5c253db9e078/media_ui/src/main/java/edu/artic/media/ui/AudioDetailsFragment.kt#L153) sometimes fail to...

Cliabhach

This codebase has changed a lot since the first commit. @sam33rdhakal and myself will undertake a basic audit, looking for the following things: - Code we don't understand - Duplicated...

Cliabhach

# The issue As it stands at v1.0, there are some significant quantities of code duplication between * `WelcomeTourCellViewModel` and `AllToursCellViewModel` * `WelcomeEventCellViewModel` and `AllEventsCellViewModel` * `WelcomeExhibitionCellViewModel` and `AllExhibitionsCellViewModel` *...

Cliabhach