Arseny Sher

Results 57 comments of Arseny Sher

> So is this something worth fixing then, if it self-heals? Yes. 1) If subscriber lags a lot it might take a long time to download everything, and currently it...

> Yes I ran pgindent locally but it reformatted a lot more stuff than just this PR walproposer code should be decent. You can run pgindent on selected files by...

> could #[ignore] if that is the intention. yes, it was. didn't know about ignore, nice

Hmm. During yesterday call I assumed that we always remove the previous version before uploading the next one (ever have max 1 uploaded); now looking at the code I see...

> It is simple, but the filename becomes quite long, I'm afraid to hit S3 filename limit eventually. WDYT? Should be ok, limit is 1024 in both s3 and azure...

LGTM. Let's put PR description to wal_backup_partial.rs head comment.

The last time in similar situation I just manually added exclusion to test_compatibility code.