spyne icon indicating copy to clipboard operation
spyne copied to clipboard

Bugfix/return client errors

Open sashawood opened this issue 3 years ago • 2 comments

Handle 2 cases where bad client data cause a 500 Internal Server Error, rather than the nicer soap11env:Client.XMLSyntaxError.

Case 1: Client does not send body in its request. This causes an empty generator to be passed to _parse_xml_string, which causes an unhandled StopIteration exception.

Case 2: Client sends badly encoded data in its request. This causes a badly encoded byte string to be passed to _parse_xml_string, which causes a UnicodeDecodeError when we try to decode it.

sashawood avatar Aug 14 '22 21:08 sashawood

Can one of the admins verify this patch?

arskom-jenkins avatar Aug 14 '22 21:08 arskom-jenkins

hey, thanks for the patch. i'm sorry these seem to have totally evaded my attention, looking into these right now

plq avatar Jan 10 '23 14:01 plq