dupeguru icon indicating copy to clipboard operation
dupeguru copied to clipboard

Make selected into reference doesn't work if one of the files are in a "pre-set" preference directory

Open bjork66 opened this issue 3 years ago • 7 comments

Describe the bug When selecting "make selected into reference" on a duplicate file, and another file that's already marked as reference is in a pre-set reference directory, it will not change to my selection..

To Reproduce Steps to reproduce the behavior: see above..

Desktop (please complete the following information): Linux mint 19 Screenshot from 2020-09-10 13-42-41

bjork66 avatar Sep 10 '20 11:09 bjork66

I believe this is working as intended. If you set the directory as "reference", then you are telling the program that any file found in it should be a reference. If you want more flexibility and still have files marked as reference automatically based on their holding directory, you should set all directories as "Normal" and use the "Re-prioritize Results" feature.

glubsy avatar Sep 10 '20 13:09 glubsy

Re-prioritize feature?

I understand you thought pattern, and I agree, to some part, however, even thou you have set the reference directories, it's still possible that you will find a better version of the file, a higher resolution, bit, or something, and want to keep that file instead of the one in the reference directory.

bjork66 avatar Sep 11 '20 04:09 bjork66

or might I suggest an alternative.. what if you make it possible for the user to check the reference file for deletion, just like the "other", that way the user can choose to delete the one in the reference directory and keep the others?

bjork66 avatar Sep 11 '20 08:09 bjork66

That's what "re-prioritize" is for. It's like considering files from a certain directory as references by default, but you can still override that by marking other files as reference in their place.

glubsy avatar Sep 11 '20 10:09 glubsy

well, not if the file was found in a directory you specified as reference, then you can't change it by clicking another file and select "make selected into reference"

bjork66 avatar Sep 12 '20 03:09 bjork66

This is why I wrote:

you should set all directories as "Normal" and use the "Re-prioritize Results" feature.

glubsy avatar Sep 12 '20 10:09 glubsy

This would be solved by solving https://github.com/arsenetar/dupeguru/issues/924 which would allow easy re-prioritization this way.

Dobatymo avatar Mar 11 '22 02:03 Dobatymo