koala icon indicating copy to clipboard operation
koala copied to clipboard
verified publisher icon arsduo

Add new http_component that would return the body of the response and custom error messages.

Open pri1012 opened this issue 1 year ago • 5 comments

Description:

This PR includes changes which will help use the latest koala version when http_component is set

Changes included:

  • Parsing of response: when http_component is set, we receive Koala::Http_service response instead of a hash and generate_results method handles only JSON response. This affects all batch request.

  • Custom Error message when the body is nil

pri1012 avatar Jan 10 '24 04:01 pri1012

@ylecuyer @arsduo Could you please help review this PR? Context: https://github.com/arsduo/koala/pull/648

saikambaiyyagari avatar Apr 04 '24 21:04 saikambaiyyagari

Gentle bump! @ylecuyer @arsduo Could you please help review this PR? Context: https://github.com/arsduo/koala/pull/648

saikambaiyyagari avatar Apr 29 '24 11:04 saikambaiyyagari

@ylecuyer & @arsduo nudge. what if anything can we do to help move these PRs along? Is there anything I can do to help get this moving?

zenspider avatar Apr 30 '24 22:04 zenspider

@ylecuyer & @arsduo gentle nudge. Folks, we have addressed the review comments. Can we get your reviews and 👍🏾 if everything is OK?

saikambaiyyagari avatar May 07 '24 00:05 saikambaiyyagari

@ylecuyer & @arsduo 🎗️ Can we get your reviews and 👍🏾 if everything is OK?

saikambaiyyagari avatar May 13 '24 00:05 saikambaiyyagari

nudge, pt deux... is there anything I can do to help move this along?

I believe this PR is the last thing standing in between us and getting off an old fork that is holding back our ability to upgrade faraday (among other things).

zenspider avatar May 30 '24 17:05 zenspider

@ylecuyer & @arsduo Gentle remainder🎗️ Can we get your reviews and 👍🏾 if everything is OK? Please

saikambaiyyagari avatar Jun 24 '24 13:06 saikambaiyyagari