koala icon indicating copy to clipboard operation
koala copied to clipboard
verified publisher icon arsduo

Handle response when http_component is set and include logging of x-fb-debug, x-fb-rev

Open pri1012 opened this issue 6 years ago • 3 comments

Description:

This PR includes changes which will help use the latest koala version when http_component is set

Changes included:

  • Parsing of response: when http_component is set, we receive Koala::Http_service response instead of a hash and generate_results method handles only JSON response. This affects all batch request.
  • include x-fb-trace-id and x-fb-debug x-fb-rev as part of the error_message returned

[X] My PR has tests and they pass!

pri1012 avatar Mar 29 '19 05:03 pri1012

@ylecuyer bumping this for consideration when you have a moment 🙏

codealchemy avatar Oct 24 '23 18:10 codealchemy

I checked the code and the PR is mixing 3 things afaics. Would you mind splitting it and making on per per change, namely:

  1. adding a new http_component that would return the body of the response
  2. adding the new debug headers
  3. returning custom error when the body is nil

this way review will be easier and changes will appear clearly in the changelog

ylecuyer avatar Nov 09 '23 19:11 ylecuyer

@ylecuyer 1 & 3 : https://github.com/arsduo/koala/pull/685, 2 separate commits 2: https://github.com/arsduo/koala/pull/686

cc @codealchemy

pri1012 avatar Jan 10 '24 05:01 pri1012

@ylecuyer I have now fixed the failing units tests. Could you please help review the below PRs.

  1. https://github.com/arsduo/koala/pull/685 2: https://github.com/arsduo/koala/pull/686 cc @arsduo

pri1012 avatar Mar 27 '24 23:03 pri1012