koala icon indicating copy to clipboard operation
koala copied to clipboard

AuthenticationError is no longer thrown

Open brendancf opened this issue 11 years ago • 4 comments

Looks like Facebook changed the error_info['type'] from OAuthException to OAuthBaseException. So the mapping code in graph_api check_response is no longer doing the proper mapping of the response to AuthenticationError

brendancf avatar Oct 08 '14 16:10 brendancf

Thanks for the report. If you can submit a pull request I can merge it, otherwise I'll hack on that soon.

arsduo avatar Oct 13 '14 18:10 arsduo

@brendancf I don't believe this has changed. From what i can see and from the documentation it's still OAuthException https://developers.facebook.com/docs/graph-api/using-graph-api/v2.1#errorcodes

nburkley avatar Oct 14 '14 14:10 nburkley

You trust the facebook documentation?!  I'm basing this off of my server lighting up with a different exception in this situation that I had before.  I'll check again to make sure I'm not missing anything.

On Tue, Oct 14, 2014 at 7:52 AM, nburkley [email protected] wrote:

@brendancf I don't believe this has changed. From what i can see and from the documentation it's still OAuthException

https://developers.facebook.com/docs/graph-api/using-graph-api/v2.1#errorcodes

Reply to this email directly or view it on GitHub: https://github.com/arsduo/koala/issues/408#issuecomment-59058269

brendancf avatar Oct 14 '14 19:10 brendancf

What did you end up finding? If you want to submit a PR (ideally one that would work in both situations) I'm definitely open to it. Not sure I'll have time to look into it otherwise, as the last few months have shown.

arsduo avatar Dec 27 '14 12:12 arsduo