tdlib-purple icon indicating copy to clipboard operation
tdlib-purple copied to clipboard

Pull out API id and hash as runtime configurable parameters

Open zer0def opened this issue 3 years ago • 5 comments

Ever since bumping tdlib-purple against tdlib>=1.7, users can experience 14:09 <@root> telegram-tdlib - Login error: Authentication error: code 400 (API_ID_PUBLISHED_FLOOD), which may necessitate them to generate their own API keys and recompile tdlib-purple with -DAPI_ID=<id> -DAPI_HASH=<hash>.

This patch moves these parameters from being specified at compile time to run time.

zer0def avatar Dec 07 '21 15:12 zer0def

But someone who builds and publishes packages (such as myself) must still be able to specify API key at compile time so that users won't have to.

ars3niy avatar Dec 07 '21 16:12 ars3niy

Do you mean "specify an alternate default API key" at compile time?

zer0def avatar Dec 07 '21 16:12 zer0def

Yes, a package built by me should use my personal API key at least by default.

ars3niy avatar Dec 07 '21 18:12 ars3niy

Already adjusted the patch to cater to that use case.

zer0def avatar Dec 07 '21 18:12 zer0def

Hello, I tested this PR and it works fine for me. I was able to enter the API information when adding the account in pidgin.

c0dev0id avatar Jan 10 '22 08:01 c0dev0id

Hey everyone and especially zer0def, I've collected all open PRs into my master branch. I don't make any promises about keeping it up-to-date though.

https://github.com/BenWiederhake/tdlib-purple/#new-libpurple-plugin-for-telegram

BenWiederhake avatar Feb 04 '23 15:02 BenWiederhake