type-x icon indicating copy to clipboard operation
type-x copied to clipboard

Old CSS style overrides are "sticking" even after deletion

Open thundernixon opened this issue 6 years ago • 5 comments

To try out the "CSS STYLES" feature, I added color: red while I was also looking at a website with Hobeaux overriding the fonts.

After deleting this override, I was surprised to see that effect still overriding page styles, after deleting and adding new "font overrides."

Here's a screenshot showing the issue, along with the devtools showing how the CSS overrides weren't quite deleted, even though they appear to be in the extension itself.

image

thundernixon avatar May 27 '19 15:05 thundernixon

I can't replicate this in the current master 🤔 Do you have steps how to reproduce this?

By the looks of it there's still PT Sans and Hobeaux being applied (but all overwritten by the fons that follow). The color property isn't being overridden so it remains visible. Could that have been the case here?

RoelN avatar May 27 '19 18:05 RoelN

The color property isn't being overridden so it remains visible. Could that have been the case here?

Yes, that seems to be exactly what was happening.

I am not experiencing it in the latest master, but I'll let you know if it turns up again. As far as I can tell, the problem is gone!

thundernixon avatar May 27 '19 20:05 thundernixon

Okay, coming across this issue again. Here are the steps I took:

  1. Delete Recursive Sans
  2. Add override, change to Hobeaux
  3. Add override, change to SignPainter, set it to h1, and give that a font-size: 48px
  4. Toggle extension off and on
  5. Delete Hobeaux and SignPainter overrides
  6. Add override, change to Recursive Sans

SignPainter is still "sticking" as the style for H1. This was fixed by a simple hard refresh, and now I'm not able to reproduce it consistently, but only sometimes ... so, this isn't very helpful other than to say sometimes, styles still seem to hang around longer than I expect. Potentially, we should warn people of it, and ideally, we could find a way to prevent it.

One possibility: if the "apply changes" button were always available, might that provide a simple and intuitive way for users to "kick the machine" if old styles were sticking?

thundernixon avatar May 28 '19 20:05 thundernixon

Is this still an issue? I didn't come across it myself, and is fixes/nullified by the "live update" feature. Otherwise close this issue?

RoelN avatar Nov 13 '19 10:11 RoelN

Hmm, I just experienced this again after using the "reset" function.

I had applied letter-spacing: 0.2em for a display font, then reset, and then noticed that when I began using a text font, it had way too much spacing.

arrowtype avatar Dec 02 '19 15:12 arrowtype