Add Locale Tests
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
- [x] 🧪 Added tests for changed code.
- [x] 🛠️ All tests pass when run locally (run
toxormake testto find out!). - [x] 🧹 All linting checks pass when run locally (run
tox -e lintormake lintto find out!). - [x] 📚 Updated documentation for changed code.
- [x] ⏩ Code is up-to-date with the
masterbranch.
If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!
Description of Changes
Closes: #1022
Added test cases for the languages that were not in in the test_locale file based on their related Locale class data.
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:warning: Please upload report for BASE (master@edfff3c). Learn more about missing BASE report.
:warning: Report is 2 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #1236 +/- ##
==========================================
Coverage ? 100.00%
==========================================
Files ? 10
Lines ? 2315
Branches ? 358
==========================================
Hits ? 2315
Misses ? 0
Partials ? 0
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I just want to mention for Romansh and Catalan languages although there are translation for "week" and "weeks" but it seems that they can not generate translation for "weeks". I removed the tests related to "weeks" for these two so that there wouldn't be a test for something not implemented. I would be glad to know if this is okay or do I need to add them.
Thank you.
Hey @ABolouk, mind fixing the linting as well?