arrow icon indicating copy to clipboard operation
arrow copied to clipboard

fix: Added type hint for start and end datetime for interval

Open inzamrzn918 opened this issue 4 months ago โ€ข 3 comments

Added type hint for start and end datetime for interval

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • [ โœ“] ๐Ÿงช Added tests for changed code.
  • [โœ“ ] ๐Ÿ› ๏ธ All tests pass when run locally (run tox or make test to find out!).
  • [โœ“ ] ๐Ÿงน All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • [ โœ“] ๐Ÿ“š Updated documentation for changed code.
  • [ โœ“] โฉ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

This PR will fix issue "Closes: #1210", which is a bug related to type hint

inzamrzn918 avatar Oct 04 '25 19:10 inzamrzn918

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :warning: Please upload report for BASE (master@b247ad0). Learn more about missing BASE report. :white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             master     #1230   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?        10           
  Lines             ?      2315           
  Branches          ?       358           
==========================================
  Hits              ?      2315           
  Misses            ?         0           
  Partials          ?         0           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 04 '25 19:10 codecov[bot]

@krisfremen , Can you please complete the review

inzamrzn918 avatar Oct 10 '25 16:10 inzamrzn918

Had one comment - thanks for your contribution

jadchaar avatar Oct 18 '25 16:10 jadchaar

Hi @inzamrzn918 mind adding a unit test? Then we can close this out.

jadchaar avatar Dec 25 '25 02:12 jadchaar