arrow icon indicating copy to clipboard operation
arrow copied to clipboard

You now have robust error handling for malformed format strings in Da…

Open Sushanth145 opened this issue 7 months ago • 2 comments

…teTimeParser.parse, preventing "list index out of range" or "no such group" errors, and getting clear, actionable error messages instead.

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • [x] 🧪 Added tests for changed code.
  • [ ] 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • [x] 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • [ ] 📚 Updated documentation for changed code.
  • [x] ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Sushanth145 avatar May 28 '25 14:05 Sushanth145

Codecov Report

:x: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 99.82%. Comparing base (403c29f) to head (2fe7e2e). :warning: Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
arrow/parser.py 63.63% 4 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##            master    #1212      +/-   ##
===========================================
- Coverage   100.00%   99.82%   -0.18%     
===========================================
  Files           10       10              
  Lines         2324     2340      +16     
  Branches       357      358       +1     
===========================================
+ Hits          2324     2336      +12     
- Misses           0        4       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 28 '25 14:05 codecov[bot]

i will add the tests to i

Sushanth145 avatar May 28 '25 17:05 Sushanth145

Feel free to reopen the PR if you revisit this in the future.

krisfremen avatar Sep 11 '25 01:09 krisfremen