arrow icon indicating copy to clipboard operation
arrow copied to clipboard

added week and quarter to persian/farsi

Open Crimson-Amir opened this issue 1 year ago • 6 comments

There was no equivalent of week and quarter in Persian language. I use this library and I had to use try-except to handle the week and this made me do this contribute.

Crimson-Amir avatar Oct 02 '24 23:10 Crimson-Amir

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (403c29f) to head (2648f45). Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1190   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2324      2324           
  Branches       357       357           
=========================================
  Hits          2324      2324           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 02 '24 23:10 codecov[bot]

Thanks @Crimson-Amir for the contribution. Mind adding some unit tests?

jadchaar avatar Oct 18 '24 03:10 jadchaar

@Crimson-Amir would it be possible to add some unit tests? Then we can merge this in.

jadchaar avatar Oct 19 '24 14:10 jadchaar

Sure

Crimson-Amir avatar Oct 19 '24 15:10 Crimson-Amir

Hey @Crimson-Amir thanks for adding tests. Mind running tox -e lint to fix the linting issues?

jadchaar avatar Oct 21 '24 02:10 jadchaar