arrow icon indicating copy to clipboard operation
arrow copied to clipboard

Use guaranteeCase in CircuitBreaker instead of addSuppressed

Open kyay10 opened this issue 4 weeks ago • 1 comments

Part of the effort to unify addSuppressed usages, this delegates to guaranteeCase; as a nice bonus, the code is cleaner!

kyay10 avatar Nov 29 '25 22:11 kyay10

Kover Report

File Coverage [91.56%]
arrow-libs/resilience/arrow-resilience/src/commonMain/kotlin/arrow/resilience/CircuitBreaker.kt 91.56%
Total Project Coverage 47.12%

github-actions[bot] avatar Nov 29 '25 22:11 github-actions[bot]

@kyay10 sorry for all the back and forth. I thought splitting arrow-exception-utils would solve the dependency on arrow-fx-coroutines problem, but it doesn't. I think adding that dependency to arrow-resilience is not that bad, and that allows us to unify behavior everywhere. So I would say, let's go with this approach!

serras avatar Dec 14 '25 07:12 serras

@kyay10 I've rebased the branch on the latest main. Feel free to merge if the rebased version is OK for you.

serras avatar Dec 14 '25 08:12 serras