arrow icon indicating copy to clipboard operation
arrow copied to clipboard

Re-add accumulating errors tests

Open nomisRev opened this issue 3 years ago • 0 comments

For Arrow 2.0 we're merging Either and Validated, we're doing so in multiple PRs and removed the accumulate error tests (traverseValidated). This issue lists the removed tests that need to be re-added for when the functionality is re-introduced in a subsequent PR for Arrow 2.0

  • zip => ValidatedTest (=> Rename "Cartesian builder" to zip)

    • [ ] zip should return Valid(f(a)) if both are Valid
    • [ ] zip should return first Invalid found if is unique or combine both otherwise
    • [ ] Cartesian builder should build products over homogeneous Validated
    • [ ] Cartesian builder should build products over heterogeneous Validated
    • [ ] Cartesian builder should build products over Invalid Validated
    • [ ] Cartesian builder for nel doesn't need semigroup parameter
  • [ ] mapAccumulating => IterableTest

    • [ ] traverse Validated stack-safe
    • [ ] traverse Validated accumulates
  • [ ] parMapAccumulating => ParTraverseValidatedTest =>

  • [ ] parMapAccumulating => ParTraverseValidatedJvmTest

nomisRev avatar Sep 06 '22 10:09 nomisRev