arrow-incubator icon indicating copy to clipboard operation
arrow-incubator copied to clipboard

AQL instances for IO, Observable, Flux, Deferred...

Open pakoito opened this issue 5 years ago • 5 comments

We need to expand the AQL instance family to effects :D

pakoito avatar Nov 25 '18 03:11 pakoito

I want to try this one, but I got some questions. For those instances, what would be the approach?

I'm asking because Either does not have where combinator because it does not have an instance of FunctorFilter. This would be the same for effects? Or should I create those instances and then create the combinators?

In case of Either, shouldn't Where (and FunctorFilter) instance be created too?

alissonfpmorais avatar Dec 12 '18 17:12 alissonfpmorais

Or should I create those instances and then create the combinators?

That's the plan, fill the gaps ;)

pakoito avatar Dec 12 '18 17:12 pakoito

Okey dokey! Starting it :D

alissonfpmorais avatar Dec 12 '18 20:12 alissonfpmorais

Sorry about the long time without working on this. Sent a PR to fix it. Let me know if something has to be changed :)

alissonfpmorais avatar Mar 07 '19 22:03 alissonfpmorais

It's an awesome PR! There are some things to change but overall it's an awesome job :D

pakoito avatar Mar 07 '19 23:03 pakoito