Reid D McKenzie

Results 86 comments of Reid D McKenzie
trafficstars

Re: ordered choice, would it be possible to parameterize the bnf parser on the ordered choice (or other) operators? I'm thinking something like `:ordered-choice #"||"` Re: files, Okay cool. it...

I agree that making `[^\s]/[^\s]` mean something other than `\s/\s` is going to cause problems. I did a little reading and it looks like `/` is indeed the traditional ordered...

This is due to the treatment of `,` as simple whitespace by rewrite-clj, currently being addressed over there in xsc/rewrite-clj#44

`[rewrite-clj "0.5.0"]` brings `:comma` nodes which makes this more tractable. https://github.com/xsc/rewrite-clj/releases/tag/clojars-0.5.0

So I use `,,` as a line prefix in require/import forms since none of the indenters happen to understand or format prefix lists meaningfully and that trick happens to work...

@mitchelkuijpers awesome! Thanks for taking this up, I glanced at it a few weeks ago and didn't get anywhere. As you work on this, I'd keep a critical eye on...

Apologies for casting stones, my point was more that neither spec provides line break specifications, nor term repetition nor patterns and all of those both seem to be stumbling blocks...

IMO if a user has inserted one or more newlines (which is as of recently its own token rather than being just whitespace) into a binding vector between a name...

That said, thank you very much for putting together this PR. I've really wanted this feature for a while now :smile:

`core.cache` is probably low enough churn that you can safely depend on it without causing issues for users, but unless this has clear performance gains even in the library "general...