arrayfire-rust icon indicating copy to clipboard operation
arrayfire-rust copied to clipboard

Published 20 hours ago • verified publisher icon arrayfire

Support implicit promoting with f16

Open Benjamin-Philip opened this issue 2 years ago • 5 comments

Closes #320

  • Create a ImplicitPromote trait and implement it for other types
  • Implement ImplicitPromote<T> traits for f16

Benjamin-Philip avatar Jun 08 '22 13:06 Benjamin-Philip

I think the clippy errors are inherited from the current HEAD.

Benjamin-Philip avatar Jun 11 '22 03:06 Benjamin-Philip

@9prady9 I think this is good to go. I made additional changes for f16 for other functions but I was having a problem with the negate function. I think the problem is that the num package does support half::f16 but I am not sure.

umar456 avatar Jul 18 '22 14:07 umar456

@umar456 thanks umar, will take a look at it soon.

9prady9 avatar Jul 19 '22 06:07 9prady9

I think the clippy errors are inherited from the current HEAD.

I took care of those, thanks for letting me know.

9prady9 avatar Sep 11 '22 12:09 9prady9

@9prady9 I think this is good to go. I made additional changes for f16 for other functions but I was having a problem with the negate function. I think the problem is that the num package does support half::f16 but I am not sure.

thank you. Documentation is not clear on that one, I will check that once more.

9prady9 avatar Sep 11 '22 19:09 9prady9

Could we also update the half 1.5.0 to half 2.2.0 in arrayfire-rust? to get new features

BA8F0D39 avatar Dec 31 '22 21:12 BA8F0D39