Arr00

Results 26 comments of Arr00

Just wanted to leave an update here--we are currently leaning towards just merging #5290 which moves in the direction of deprecating `hashProposal` eventually in favor of a `view` function named...

This seems like a reasonable feature request to me. Feel free to make a PR and we will try to have more constructive comments there.

Maybe address the risk of quantum computing for the internal storage structure.

What does `block.timestamp` return on sub-second blockchains? Milliseconds?

I don't think we should be changing the existing contracts for this... but we should support it. Maybe we should have contracts involving timestamps be generated from templates?

Why are we updating mocks? Aren't they skipped by default?

When running locally I do see that--but you can see that setting it back to that version in CI silences the error. Regardless, it is still a false positive but...

Ok, we can do that if necessary. Do you know this is only being surfaced now with the new release?

Following up on this. `hardhat_setChainId` approach would be better as it would allow setting the chain id without resetting state (simulation of a network fork), but is quite a bit...