smart-testing icon indicating copy to clipboard operation
smart-testing copied to clipboard

Rename smart testing properties so user can use it quickly

Open dipak-pawar opened this issue 7 years ago • 12 comments

Currently all smart testing properties are defining using prefix smart.testing.

Currently user have to type entire smart.testing while applying each property for smart testing.

We can change that prefix from smart.testing to st, so user can write quickly all required properties to run using smart testing.

So after this change property should look like: smart.testing.mode -> st.mode smart.testing -> st smart.testing.report.enable -> st.report.enable

dipak-pawar avatar Aug 31 '17 06:08 dipak-pawar

st is ambiguous. I believe for the same reason surefire is not sf. Also keep in mind that we aim for having configuration file instead and properties will only be used in special situations when you really want to overwrite something for given environment.

bartoszmajsak avatar Aug 31 '17 06:08 bartoszmajsak

If it is ambiguous, then can we have some short name which is not ambiguous?

After configuration file we are not solving this problem 100%. User has to use it whenever he wants to overwrite.

dipak-pawar avatar Aug 31 '17 06:08 dipak-pawar

But it's documented, so I don't really see much of a benefit of having this shorten because you still need to know what comes after that. Most of the times the way how it works is that you look to the documentation and copy property to script/cli with the proper value. Not much to remember here by heart.

bartoszmajsak avatar Aug 31 '17 07:08 bartoszmajsak

If it is ambiguous, then can we have some short name which is not ambiguous?

I'm open to suggestions

After configuration file we are not solving this problem 100%. User has to use it whenever he wants to overwrite.

But the central point will be file, as exceptional cases would work the same way as described above - pasting properties from the docs (unless we provide some completion from the terminal which is another option)

bartoszmajsak avatar Aug 31 '17 07:08 bartoszmajsak

Maybe we could create some short alias so it is not a replacement butban addition, so there is the property and then a short alias

El 31 ago. 2017 9:04 a. m., "Bartosz Majsak" [email protected] escribió:

If it is ambiguous, then can we have some short name which is not ambiguous?

I'm open to suggestions

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/arquillian/smart-testing/issues/123#issuecomment-326209078, or mute the thread https://github.com/notifications/unsubscribe-auth/ABcmYUd5Ga8Rhsa14iE-JfgbQLz0rx9Mks5sdlrzgaJpZM4PIXgm .

lordofthejars avatar Aug 31 '17 07:08 lordofthejars

I was thinking about that too, but I am not really sure how much of pain it is to remember smart.testing vs st. From my personal point of view - not an issue at all.

bartoszmajsak avatar Aug 31 '17 07:08 bartoszmajsak

The real issue is that we have too many properties now - that's why we should have a config file and curated list of the minimal amount of properties.

bartoszmajsak avatar Aug 31 '17 07:08 bartoszmajsak

it's not pain of remembering, it's pain of typing extra letters(I know which are taking seconds), but I believe if we provide alias then it would be beneficial for end user

dipak-pawar avatar Aug 31 '17 10:08 dipak-pawar

But I think that in both cases user would do copy paste from docs to script. This makes me think about improving docs with a copy to clipboard button

El 31 ago. 2017 12:37 p. m., "Dipak Pawar" [email protected] escribió:

it's not pain of remembering, it's pain of typing of extra letters(I know which are taking seconds), but I believe if we provide alias then it would be beneficial for end user

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/arquillian/smart-testing/issues/123#issuecomment-326257662, or mute the thread https://github.com/notifications/unsubscribe-auth/ABcmYQE0DgS6O-zKsoMu00-_tSHlIGOGks5sdoz3gaJpZM4PIXgm .

lordofthejars avatar Aug 31 '17 11:08 lordofthejars

Awesome idea @lordofthejars. It could actually copy property with all possible values, so user could just delete all not needed ones. WDYT?

bartoszmajsak avatar Aug 31 '17 11:08 bartoszmajsak

+1

El 31 ago. 2017 1:45 p. m., "Bartosz Majsak" [email protected] escribió:

Awesome idea @lordofthejars https://github.com/lordofthejars. It could actually copy property with all possible values, so user could just delete all not needed ones. WDYT?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/arquillian/smart-testing/issues/123#issuecomment-326271066, or mute the thread https://github.com/notifications/unsubscribe-auth/ABcmYRHLySyZ1OuChekBJC3F1HEGYs1uks5sdpzSgaJpZM4PIXgm .

lordofthejars avatar Aug 31 '17 11:08 lordofthejars

Another thing would be to add our properties to mvn autocompletion scripts - I would avoid adding it to any upstream project, but have a nice way to provide an "add-on" for it.

The integration I'm currently using is https://github.com/robbyrussell/oh-my-zsh/blob/master/plugins/mvn/mvn.plugin.zsh. Maybe we could add some smart snippet looking for extra properties.

bartoszmajsak avatar Aug 31 '17 12:08 bartoszmajsak