smart-testing icon indicating copy to clipboard operation
smart-testing copied to clipboard

Enable smart testing to run against smart testing repository

Open dipak-pawar opened this issue 7 years ago • 2 comments

Enable smart testing to run against smart testing repository.

Currently in smart testing, we are running all tests in surefire parallel mode configuration with reuseFork=true.

Issues

  • If we enable smart testing for this repository, getting following cyclic dependency exception:
[ERROR] [ERROR] The projects in the reactor contain a cyclic reference: Edge between 'Vertex{label='org.arquillian.smart.testing:smart-testing-surefire-provider:0.0.1-SNAPSHOT'}' and 'Vertex{label='org.arquillian.smart.testing:smart-testing-core:0.0.1-SNAPSHOT'}' introduces to cycle in the graph org.arquillian.smart.testing:smart-testing-core:0.0.1-SNAPSHOT --> org.arquillian.smart.testing:smart-testing-surefire-provider:0.0.1-SNAPSHOT --> org.arquillian.smart.testing:smart-testing-core:0.0.1-SNAPSHOT @ 
[ERROR] The projects in the reactor contain a cyclic reference: Edge between 'Vertex{label='org.arquillian.smart.testing:smart-testing-surefire-provider:0.0.1-SNAPSHOT'}' and 'Vertex{label='org.arquillian.smart.testing:smart-testing-core:0.0.1-SNAPSHOT'}' introduces to cycle in the graph org.arquillian.smart.testing:smart-testing-core:0.0.1-SNAPSHOT --> org.arquillian.smart.testing:smart-testing-surefire-provider:0.0.1-SNAPSHOT --> org.arquillian.smart.testing:smart-testing-core:0.0.1-SNAPSHOT -> [Help 1]
  • We have issue #94 which needs to be resolved for this or run it with reuseForks=false flag.

Benefits

  • Reduce build time
  • Real time testing of our tool with every PR.

dipak-pawar avatar Aug 28 '17 09:08 dipak-pawar

Thanks for reporting.

Real time testing of our tool with every PR.

This we have with Test Bed, don't we?

Reduce build time

I would still run the full build or run several steps build, but always be sure we are not breaking things.

bartoszmajsak avatar Aug 28 '17 15:08 bartoszmajsak

Real time testing of our tool with every PR.

This we have with Test Bed, don't we?

Yes we do have test bed for this. but still if we used it with our project then we can find some corner cases which we can't find it using test bed, because in test-bed we are using same set of tests for new, affected, modifed.

Reduce build time

I would still run the full build or run several steps build, but always be sure we are not breaking things.

Agreed. But I would opt for running entire functional-tests using test-bed as part of build & we can configure smart-testing to use for other remaining sub-modules.

Along with this we can show to our users we are using our tool in production.

dipak-pawar avatar Aug 28 '17 17:08 dipak-pawar