arquillian-cube icon indicating copy to clipboard operation
arquillian-cube copied to clipboard

Allow browser image, name and port override and enhance for DinD

Open AndyGee opened this issue 5 years ago • 1 comments

In a CI environment the DockerUri and DockerServer may not be interchangeable if the CI is not the actual DinD server, rather it has started and mapped a DinD runner.

If image XYZ is exposing port 4321 and dockerInsideDockerResolution is true (default) and the container is started by the DinD then dockerServerIp:4321 will be accessible.

However, if the DinD host is a runner then dockerInsideDockerResolution is false (ie. dockerServerIp is not the DinD), and the serverUri host should be used (which will be set to something like http://myDindAlias:2375), somyDindAlias:4321 will be accessible.

I'll provide a better description with diagrams in a later PR. It's complicated at best ;-)

Changes proposed in this pull request:

  • Browser image, name and port override and enhance for DinD.
  • Fixed a few tests for windows and updated for DinD.
  • Providing more useful logging.
  • Set the recommended minimum SHM size for selenium container.

Fixes #1107

AndyGee avatar May 13 '19 20:05 AndyGee

@AndyGee @lordofthejars are we moving forward with this PR?

bartoszmajsak avatar Jul 08 '20 09:07 bartoszmajsak