Andy Porter

Results 146 issues of Andy Porter

While working on https://github.com/stfc/PSycloneBench/pull/87 it turns out that `OMPTargetTrans` happily puts directives around a loop that does both a reduction and a WRITE. At the very least it should spot...

bug
NEMO
PSyIR

Currently the majority of the builtin tests are in `domain/lfric/lfric_builtins_test.py` and `domain/lfric/lfric_integer_builtins_test.py` but they are huge. Therefore a new `domain/lfric/builtins` directory has been created and tests for each builtin should...

enhancement
LFRic
good first issue

A literal such as `1.0_wp` requires that the `wp` symbol is in scope. However, discovering that currently requires walking the tree to find all `Literal` instances and then checking whether...

PSyIR

Currently eg20 just generates an algorithm *subroutine* however @hiker says: "I could get this to compile with our infrastructure files by adding function_space_collection_mod.F90 to our infrastructure (with a small change...

enhancement
LFRic

At the moment Transformations have `excluded_node_types` and Nodes have `validate_global_constraints()`. When generating code, we also need to check whether we should be putting calls relating to distributed memory (halo exchanges...

enhancement
question

At the moment we have to document the examples twice - once in doc/user_guide/examples.rst and again in the appropriate README.md under the examples directory. In #1669 @hiker suggested finding a...

Currently ACCEnterDataTrans is only supported for the GOcean API. We will need it for the NEMO API if we are to generate efficient OpenACC code.

in progress
NEMO

Currently there's nothing stopping us adding a Symbol with an import interface to a table, even if that import interface refers to a ContainerSymbol that is not in that table...

bug
PSyIR

Currently the dependence analysis cannot do anything with CodeBlock nodes. However, in many cases it should be possible to identify which symbols are read and which are written and that...

enhancement
PSyIR