Andy Porter

Results 756 comments of Andy Porter

Well, #2435 does a little better - it does at least rename the routines listed within the interface: interface combine_w2_field_code module procedure :: adj_combine_w2_field_code_r_single, adj_combine_w2_field_code_r_double end interface combine_w2_field_code however, the...

The problem is that we don't yet appear to properly support mixed precision kernels: https://github.com/stfc/PSyclone/blob/afed0a940a9955fb531fb368f5d3da8fbab6fcdd/src/psyclone/psyad/domain/lfric/lfric_adjoint.py#L139-L158 The referenced issue (#2236) has been closed in favour of #2347 which itself has been...

I believe you don't quite yet have 2.5.0 (Iva's team are in the process of deploying it as we speak). However, unfortunately that isn't going to help. This needs a...

> but pylint has quite a few 'Access to protected member' in the test files - should I ignore these? For the tests, `pylint` should be run in the `tests`...

OK @mo-lottieturner and @mo-alistairp, I've gone through and resolved everything that has been done.

I can't find your comment @mo-alistairp but yes, "s/size/rank/" is my shorthand (sed notation) for replace "size" with "rank".