Andy Porter

Results 789 comments of Andy Porter

I couldn't work out where/when the declaration disappeared - it's probably when I gave up on the idea of creating a standalone program and went for an LFRic mini-app instead....

I just need to fix a few more pylint issues and check docstrings are OK now.

I'm afraid this is still quite a biggie but it's very pleasing :-) Ready for review from @rupertford or perhaps @hiker.

> One thing I found slightly confusing was the use of _test in for the harness as we obviously use that for test code as well. It might be better...

Ready for another look, assuming CI happiness.

This is also an issue in WW3 code - it prevents the application of `HoistLocalArrayTrans` to quite a number of arrays.

@hiker, I think this can be closed now as we do represent calls as `Call` nodes?

Ah, no, it doesn't have such an implementation. I *think* it will use the one in `Node` which in turn just calls `reference_accesses` for each of the child References -...

This support would also be useful when hoisting local, automatic arrays (#1634). Currently the required `allocated()` and `allocate()` calls have to be put into CodeBlocks.