Martin Tournoij

Add AddWith() to pass options, allow controlling Windows buffer size

5

This is similar to Add(), except that you can pass options. Ideally this should just be Add(), but that's not a compatible change, so we're stuck with this until we...

Support additional event types

6

We only have Create, Remove, Rename, Write, and Chmod now, but many watchers support additional events. This has come up a few times: - #24 - Extend, Link, Revoke -...

Doesn't show files if there is just a single file in a repo

1

Example: http://gocover.io/arp242.net/sconfig There is just one file, I guess the `change` event of the dropdown is never called?

It would treat an existing underscore as a "word", so one underscore got transformed in to 3. I run in to this semi-regularly when I copy something like a database...

https://gopkg.in/fsnotify.v1 lists the latest version as "v1.6.0", which is correct, but when using go get: % go get gopkg.in/fsnotify/fsnotify.v1 go: added golang.org/x/sys v0.13.0 go: added gopkg.in/fsnotify/fsnotify.v1 v1.4.7 # I'm not...

Re: TOML performance

2

I'm not sure where else to report this, but re: https://github.com/madmurphy/libconfini/wiki/An-INI-critique-of-TOML#18-performance This is really a tomlc99 issue, not a TOML issue. The problem is that it allocates memory in 1,000...

S1017: diagnostics can be confusing for `else if`, and may make code less consistent

3

I have the following code to remove UTF-16 and UTF-8 BOMs (which really shouldn't be present, but in reality are): if strings.HasPrefix(data, "\xff\xfe") || strings.HasPrefix(data, "\xfe\xff") { // UTF-16 data...

toml: only highlight inf and nan in value, highlight keys starting with digit

1

 Fixes #1636 Fixes #1873

Improve performance by increasing the buffer size to 20K

3

Reading a 5M file takes about 13 seconds. For reference: Python takes about 1.2s for the same file, Go 0.4s, and C++ about 0.25s. So there's a lot to gain!...

These are a few issues I found investigating failing test cases from toml-test, most are fairly simple low-handing fruit. There's still a few others that fail, but this already improves...