Martin Tournoij

There's a bunch of other cases with quotes that should probably trigger an error; with your patch: ``` % git diff diff --git i/staticcheck/sa5008/testdata/src/example.com/CheckStructTags/CheckStructTags.go w/staticcheck/sa5008/testdata/src/example.com/CheckStructTags/CheckStructTags.go index 37b76813..966a6464 100644 --- i/staticcheck/sa5008/testdata/src/example.com/CheckStructTags/CheckStructTags.go...

With this: ``` package main import ( "context" "time" ) func main() {} type ( Dialog struct{} Turn struct{ Reason int } ) const ( EndReasonContextExpired = iota EndReasonInterrupted )...

> The worker Clients are doing a lot more database-specific stuff beyond just simple queries including LISTEN/NOTIFY which is tightly tied to pgx.Conn as of today and would be pretty...

Yes, I'm using that for the time being. But that's only for "poll mode". What I want is "listener mode". I think we can make that work one way or...

Ah cheers, that seems very similar. I'll have a look at that later. > In your app, are you pretty much fully onboard with GORM and leveraging that all throughout...

The way I solved this, in case it might be useful for someone reading this issue in the future: // pgx connection pool. pool, _ := pgxpool.NewWithConfig(context.Background(), cfg) // database/sql,...

Is there any reason in particular you used two slices in MultiGet() rather than a slice with a struct? It seems to me that's quite a bit more convenient, and...

It seems to me that juggling around two variables for one thing is rather awkward. Then again I also don't think my version is super-great either (it was just the...

Also: there's quite a few other operations where it makes sense to operate on more than one key. Why do Get() and Set() have "Multi versions" but not Add() or...

Hm, I get quite different benchmark results? BenchmarkGetMulti/get-8 62580 17229 ns/op 0 B/op 0 allocs/op BenchmarkGetMulti/mget-8 112527 12081 ns/op 16384 B/op 1 allocs/op BenchmarkGetMulti/mget2-8 114786 10299 ns/op 10368 B/op 2...