arouel
Add Microsoft Edge as UA family
Microsoft Edge is one of the new browsers of this year and has been added as UA family to the database. The enum in uadetector doesn't support this new family type yet.
In the 11/2014 uas.xml database there were 56 user agent families that did not get mapped. With the latest database from udger.com there are now 78 family names without mapping in the enum. Did you have a certain policy of which ones to include?
@HaraldWalker I think we can add the missing families. I cannot do this, because I don't have access to the latest database from udger.com. A Pull Request is with that is always welcome.
You should have access to and can have access. See our previous mails. What is not possible is the free distribution of data, it is clear. If you modify uadetector to work with udger.com, we are ready to provide free access keys (for tests and continue). This applies particularly to "HaraldWalker" and "before". Jaroslav
@mallat a problem though are the unit tests. The unit tests should be updated to verify that the library is fully compatible with the latest version from udger.com. But due to licensing we would not be allowed to include a version of the database with this library. Would also be good if this library could at least bundle the free version you are offering. If users want the online updates then they obviously need a subscription. @before If you register on udger.com you can get a free version of the database and with the free access key @mallat is offering you can then also test the online updating feature again. The version of my pull request is compatible with the latest udger.com version. In my pull request I've already added some of the missing agent families.
@mallat as @HaraldWalker mentioned, our test cases cannot check the compatibility completely without the latest version from udger.com. Running those tests only locally for licensing reasons is limiting. Wouldn't it be worth to share a free (maybe reduced) version of the database to support the development of free software projects like this one better?
@HaraldWalker it would be cool if we change our test infrastructure in a way to grab the personal access key from ~/.m2/settings.xml to run our test cases against udger.com. Nevertheless, the current situation is limiting the development of others.
@before I tested it with both, the old uas.xml and the latest version from udger.com. A few unit tests need updates because some results are slightly different. But I left them as they are since the current unit tests depend on the old uas.xml from last year. And of course I was not able to add new test examples as the old database would not detect those. Can you configure the automated build on buildhive in a way that you can set the access key without making it public? So the unit tests that currently use the old bundled uas.xml would have to be changed to use either the online version with a key provided for instance in maven settings or with a local version in case a contributor does not have a subscription and had to download the latest version manually.