react-native-uploader icon indicating copy to clipboard operation
react-native-uploader copied to clipboard

Published 20 hours ago • verified publisher icon aroth

support Android

Open choru-k opened this issue 8 years ago • 14 comments

choru-k avatar Jul 02 '16 13:07 choru-k

This is great! Thanks for the PR -- a lot of people will benefit from your work. I will review and merge shortly.

aroth avatar Jul 03 '16 03:07 aroth

:D Could you please merge the request?

choru-k avatar Jul 07 '16 05:07 choru-k

I've had a chance to quickly review the PR. I'd like to see a few changes:

  • Naming
    • I use RNUploader, you're using RNFileTransfer. Please use RNUploader for consistency.
  • Feature Parity
    • I would like both iOS and Android versions to behave the same, including:
      • Support for POST and PUT
      • Support for custom headers
      • Support for custom params
      • Support for base64 data
      • Progress support
      • Cancellation support
  • A working example for Android under examples/.
  • Documentation
    • I'd like cleaner documentation detailing the Android implementation, but I don't mind taking care of this once I'm content with the PR.

Do you think you could take implement any of these requests such that both iOS and Android implementations support the same features?

Thank you again for your work.

aroth avatar Jul 09 '16 22:07 aroth

I'm on RN 0.32 and your module gives me "Cannot call upload of undefined" because NativeModules.FileTransfer does not exist.

Your module seems to depend on NativeModules.FileTransfer, but this does not exist for me (I console.log it out and it's NULL)

GeoffreyPlitt avatar Sep 14 '16 00:09 GeoffreyPlitt

Hi @GeoffreyPlitt -- I'll take a look with a current version of RN next week. Can you post a separate issue please?

aroth avatar Sep 14 '16 16:09 aroth

Will do

GeoffreyPlitt avatar Sep 14 '16 18:09 GeoffreyPlitt

+1

faceyspacey avatar Sep 29 '16 11:09 faceyspacey

+1

RichardLindhout avatar Oct 03 '16 18:10 RichardLindhout

+1 and I'd be happy to do the necessary updates. Would you merge a suitable version?

StevePotter avatar Dec 05 '16 22:12 StevePotter

Can we follow same name spacing between android and ios implementation?

BilalBudhani avatar Dec 06 '16 13:12 BilalBudhani

I would also add a JS interface to hide the awkward DeviceEmitter stuff that needs to go into code. So the API would be exactly the same in iOS and Android.

StevePotter avatar Dec 08 '16 02:12 StevePotter

Anyone still working on this?

superandrew213 avatar Mar 17 '17 13:03 superandrew213

I got error on sync gradle Error:Configuration with name 'default' not found.

daywong1119 avatar Apr 25 '17 14:04 daywong1119

@aroth will this lib ever support android? it looks like this PR has been abandoned

WillyRamirez avatar Jan 20 '18 13:01 WillyRamirez