om-autocomplete

om-autocomplete copied to clipboard

Various fixes [read below]

1

Hi @arosequist, Thanks for the great library, I use it and it seems to work quite well. Here's a pull request with a few proposals on things that can be...

fterrier

Future maintenance

1

Can you release this to clojars so users can use it as a library? If you're no longer using this component, would you consider moving this to [omcljs](https://github.com/omcljs/) and giving...

cldwalker

Currently a user can't submit an input value that [isn't autocompleted](https://github.com/arosequist/om-autocomplete/blob/98365aaea76950a98fd955eb68628ad0e97816ab/src/arosequist/om_autocomplete.cljs#L21). Would you take a pull to default to the input value's field if no suggestion is found?

cldwalker

Is this intended?

borkdude

Implement with WAI-ARIA Accessiblity

1

I'd love to see this component implement the combobox/autocomplete roles (and associated listbox/option roles for the container view). Here are some resources: http://www.w3.org/TR/wai-aria-practices/#combobox http://www.w3.org/TR/wai-aria/roles#combobox http://www.w3.org/TR/wai-aria-practices/#autocomplete http://www.w3.org/TR/wai-aria/states_and_properties#aria-autocomplete Currently the keyboard experience...

ryanflorence