raidplaner icon indicating copy to clipboard operation
raidplaner copied to clipboard

Aggregate player comments and split via tabs in the comment div. WIP.

Open mizaki opened this issue 10 years ago • 3 comments

This is a quick knock up of the idea to make player comments easier to read. I'm not sure where you would like the function put (guessing not in the display function?). I also had to replace jquery-ui to add the tab function (I just added everything for my ease).

Thoughts?

mizaki avatar Dec 16 '14 14:12 mizaki

First: Thanks for the pull request. As far as I can see (I'm currently at work and can only see the source) you add all comments to the raid comment field, right? I guess a better place for this would be the upcoming log tab, so I would "merge" this when I start this feature, i.e. I would integrate the same functionality into the log tab.

arnecls avatar Dec 16 '14 17:12 arnecls

Sounds good. I was wondering about the logging myself but started small. All it does is make three tabs in the raid comment div: Raid, Player and Cancelled, with a count for the player notes.

It kind of drives me crazy clicking notes atm because the double click picking/unpicking is not a double click event. Click on one comment and then click another and you've picked/unpicked someone. :)

mizaki avatar Dec 16 '14 23:12 mizaki

you can see a simple comment function in my latest commit in a fork: https://github.com/mroswald/raidplaner/commit/b70308c49becee2ed7c6812796b611bf72de2155

mroswald avatar Jul 15 '15 10:07 mroswald