cycleGAN-PyTorch icon indicating copy to clipboard operation
cycleGAN-PyTorch copied to clipboard

Confusing naming

Open MarioProjects opened this issue 4 years ago • 0 comments

Hi, your code is very clean thanks!

But I think that naming can be confusing. At https://github.com/arnab39/cycleGAN-PyTorch/blob/master/model.py#L107 you named a_fake = self.Gab(b_real), the generator of a to b taking a b example should not generate the identity (a_idt)? In all examples I show, the followed nomenclature for generators is this Gxy, generator from x to y...

Assuming that, all generators naming are reversed. What do you think?

MarioProjects avatar Feb 17 '21 11:02 MarioProjects