Adam Snyder

Results 28 issues of Adam Snyder

**Describe the bug** Custom serialization codecs (with [`codec.SetActorCodec()`](https://github.com/dapr/go-sdk/blob/a38be4e38b7d51406e366f60fc5a526d255f46e1/actor/codec/codec.go#L31)) do not seem to be working. Actor invocations are always encoded as JSON. Setting and then using a custom codec in a...

bug

Hi, while trying out the SDK I noticed some instances of incomplete error handling. This isn't a very comprehensive list; it's just what I saw while looking at the actor...

bug

This PR removes a `time.Sleep(1 * time.Second)` from `Session.Close()`. Instead, I implemented the websocket close handshake described in this comment: https://github.com/gorilla/websocket/issues/448#issuecomment-469903859 The reason I would like to see this change...

gateway
improvement

This adds test coverage to `Session.Open()` and `Session.Close()`. Test coverage is up from 10.5% to 15.8%.

See discussion in #1335. The musttag linter catches some bugs where structs are missing json tags for serialization.

### Community Note * Please vote on this issue by adding a 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to the original issue to help the community and maintainers prioritize this request * Please do...

enhancement

### Community Note * Please vote on this issue by adding a 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to the original issue to help the community and maintainers prioritize this request * Please do...

ast
check/acctest

Hi. 👋 I'm getting a false positive when I compare two structs that have a function-type field. This is using gomega version `v1.20.0`. Here's a minimal example: ```go func TestCompareFunctions_Minimal(t...