Adam Snyder

I should mention: I didn't create a category for general coding issues / bugs that would be caught by off-the-shelf static code analysis / code linting. I assumed we would...

Found https://github.com/bflad/tfproviderlint. It has checks for some general problems like using the wrong Go-type for the schema-type. It implements go/analysis so could plug into go vet or golanglint-ci.

https://github.com/bflad/tfproviderdocs can do some docs validation. At the moment it supports frontmatter validation and basic existence of doc pages.

Many of these are now covered by doc generation and linters. I think we could also add a section to CONTRIBUTING.md similar to [Golang CodeReviewComments](https://github.com/golang/go/wiki/CodeReviewComments) for common code review comments.

@Stromweld > there must be a bug in the code here as this is the only commit recently touching branch protection I think actually the behavior was introduced in #583,...

@Stromweld It's definitely worth fixing, since it's an obvious annoyance. TBH I'm not sure it's a bug, since GitLab protects the default branch by default for you when you use...

I wouldn't consider it a bug if the previous behavior only worked because of the existence of another bug. But that's just semantics, I agree there should be a solution...

The active discussion on this is in #792 if folks would like to add feedback.

API reference if anybody wants to add a new `gitlab_project_notification_settings` resource: https://docs.gitlab.com/ee/api/notification_settings.html#group--project-level-notification-settings or `gitlab_global_notification_settings` : https://docs.gitlab.com/ee/api/notification_settings.html#global-notification-settings

I saw this same discussion pop up here: https://discuss.hashicorp.com/t/sdk-provider-development-anyone-ever-used-code-generation-or-other-tools-to-simplify-their-provider-development/20301 It sounds like Terraform is not designed for this kind of dynamic model. Building a code generation tool is one way...