libart icon indicating copy to clipboard operation
libart copied to clipboard

please review SSE instructions

Open svalaskevicius opened this issue 3 years ago • 1 comments

Hi,

            cmp = _mm_cmplt_epi8(_mm_set1_epi8(c),
                    _mm_loadu_si128((__m128i*)n->keys));

isn't it comparing them as signed bytes?

I found http://www.alfredklomp.com/programming/sse-intrinsics/ with nice tips how to do unsigned compares - I hope it helps :) (or maybe I'm missing something?)

svalaskevicius avatar Mar 26 '21 22:03 svalaskevicius

Thanks, that linked helped me! I added a pull request for this.

sirainen avatar Oct 14 '21 20:10 sirainen