go-metrics icon indicating copy to clipboard operation
go-metrics copied to clipboard

Add an interface declaration for Metrics

Open bobbytables opened this issue 8 years ago • 2 comments

Also fixed some golint errors on the package level functions.

Purpose

Right now we use *metrics.Metrics as the type when we initialize things like servers or daemons with this package. This is fine in tests if you use a blackhole sink but it would be nice to just have something that guarantees the interface that we can implement ourselves for testing purposes. Since MockSink isn't exported. Alternatively we could just export the MockSink (its declared in a test file).

bobbytables avatar Mar 17 '17 19:03 bobbytables

Ping, any thoughts on this?

bobbytables avatar Nov 30 '17 17:11 bobbytables

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

hashicorp-cla avatar Sep 30 '22 21:09 hashicorp-cla