go-metrics
go-metrics copied to clipboard
Add an interface declaration for Metrics
Also fixed some golint errors on the package level functions.
Purpose
Right now we use *metrics.Metrics as the type when we initialize things like servers or daemons with this package. This is fine in tests if you use a blackhole sink but it would be nice to just have something that guarantees the interface that we can implement ourselves for testing purposes. Since MockSink isn't exported. Alternatively we could just export the MockSink (its declared in a test file).
Ping, any thoughts on this?
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes
Have you signed the CLA already but the status is still pending? Recheck it.