krop icon indicating copy to clipboard operation
krop copied to clipboard

PyPDF2 usage: New syntax / deprecations and the dependency

Open MartinThoma opened this issue 3 years ago • 1 comments

Hi!

I've noticed that krop uses PyPDF2. Is there a reason for not putting it in the setup.py as a dependency?

PyPDF2 has changed a lot since April. We try hard not to break stuff (see deprecation process), but we also want to move forward. As we modernized the API, a lot of the names changed. It's mostly switching from camelCase to snake_case, but see CHANGELOG "deprecation" for details.

MartinThoma avatar Jun 30 '22 12:06 MartinThoma

Especially under 1.28.0: https://pypdf2.readthedocs.io/en/latest/meta/CHANGELOG.html#id40

MartinThoma avatar Jun 30 '22 12:06 MartinThoma

I became the maintainer of pypdf as well and migrated the PyPDF2 project into pypdf (now all lowercase).

However, it seems to me that krop is dead.

MartinThoma avatar Jan 31 '23 08:01 MartinThoma

Thank you, Martin! It is fantastic to see pypdf so alive again :) My apologies for the horribly long silence due to too little time.

I have just added support for pypdf and the new naming scheme. pyPdf and PyPDF2 are also still supported. (The only non-supported option is PyPDF2 with the new naming scheme, which I believe only existed for a brief moment of time; if anybody desperately needs that supported as well, this could certainly be done easily.)

I will soon adjust the documentation and installation guidelines.

PS: I'll have to think about the dependency question. I'm leaning against it since krop can run (but not crop) without pypdf. Now pikepdf is an alternative option as well and more might be added. (In the past, I liked having the option of having the various needed Python packages installable from a variety of sources as well as installable after the fact.)

arminstraub avatar May 20 '23 16:05 arminstraub